Skip to content

Conversation

@stevenhua0320
Copy link

@stevenhua0320 stevenhua0320 commented Jan 21, 2026

@sbillinge Ready to review, Closes #203
P.S After the workflow run, I realized that diffpy.labpdfproc still uses the old version of workflow for test-on-pr, that is why the python version is hard-coded in the workflow and did not run the latest version of python.

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.31%. Comparing base (f1e9b63) to head (1f27449).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files           5        5           
  Lines         292      292           
=======================================
  Hits          290      290           
  Misses          2        2           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

Please see the comment in diffpy/diffpy.snmf#175

Per @stevenhua0320 comment above, @cadenmyers13 it seems that this needs to be re-scikit-packaged to bring it up to date. @stevenhua0320, @cadenmyers13 is working to get this released, but I think it could help him out if you could do the re-packaging to make sure everything is up to date.

@cadenmyers13
Copy link
Contributor

@stevenhua0320 yes that would be great if you have the bandwidth. Let me know if not

@stevenhua0320
Copy link
Author

@sbillinge I think this one could be repackaged using package update right? I could do that to make this package up to date with data structure. All I need to do is to open new PRs and make as small edits to content as possible.

@sbillinge
Copy link
Contributor

@sbillinge I think this one could be repackaged using package update right? I could do that to make this package up to date with data structure. All I need to do is to open new PRs and make as small edits to content as possible.

that is correct. There will be very little to be done I think, so it may all go in on a single PR, but just see. After this is done we can be sure htat everything is correctly aligned. However, before you do that, I think there was some work we were doing on scikit-package. Please could you look over there and see if there are any open PRs or issues? It would be good to close them and then use this to test any changes didn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for python 3.14 and remove support of python 3.11

3 participants